markalex (Mar 03 2026 at 14:03): markalex (Mar 03 2026 at 14:03):Should there be an additional RSS topic for changesets requesting a review?
I've made a change recently, that I was not 100% sure in. Since iD suggests to request review I decided to agree this time, but outside of changeset having additional tag, it doesn't seem like it is shown anywhere.
Colby (Mar 03 2026 at 15:44):can get an RSS feed from osmcha with that
osmcha
Colby (Mar 03 2026 at 15:44):would be good to have on zulip
HellMap (Mar 03 2026 at 18:41):Yeah, that's probably a good RSS to have.
markalex (Mar 04 2026 at 09:50):If I understood how current feeds work (which is not granted :slight_smile:), feed on the same site already in use also exists.
https://resultmaps.neis-one.org/osm-suspicious?country=197&hours=96&tsearch=review_requested%3Dyes&mappingdays=-1&anyobj=t&comp=%3E&value=10&action=d&obj=n&filterkey=#7/57.097/24.681
markalex (Mar 09 2026 at 18:42):It is alive!
#RSS > Find Suspicious OpenStreetMap Changesets
markalex (Mar 09 2026 at 18:45):One small issue: due to the way how bot decides on the name of channel - channel is called "Find Suspicious OpenStreetMap Changesets".
If somebody has a permission to pin a message, pinning short explanation that only changesets with request for review are shown there would be grand!
markalex (Mar 09 2026 at 18:46):Emmm, not that bot. Seems this chat has a recognition for word bot linking to address updating one =)
Colby (Mar 09 2026 at 19:01):would also be good to clean up the other names too
markalex (Mar 09 2026 at 19:05):Well, names are taken from the title of RSS.
Changing channel names would require rewriting how bot "selects" the name of channel to send message to.
markalex (Mar 09 2026 at 19:36):I looked at how bot(correct link!) it written - providing custom names for target channel is kinda possible, but it will be PITA.
Like, one would need to parse feed list, and then call bot with topic param to override destination and a dynamic feed file with a single url.
markalex (Mar 10 2026 at 19:16):I had a small go at imagining how custom names for topics would look like here. It's not as unpleasant as I expected it to be at first, but still not particularly elegant IMO.
It's not tested, because I don't have a zulip instance to test it on. For that reason - it's not a PR.
But if somebody has a good idea how to test this stuff, we can play around with that)
Rihards Olups (Mar 10 2026 at 19:20):Test in prod? =)
markalex (Mar 10 2026 at 19:21):Not in this case
markalex (Mar 10 2026 at 19:22):On the other hand, if you could create a test channel, like RSS-test, or something, we can use it
markalex (Mar 10 2026 at 19:22):Almost test in prod, I guess)
HellMap (Mar 16 2026 at 11:09):I feel like the RSS feed code needs a serious rewrite or otherwise something is wrong with feeds themselves. My notes from like 4 days ago a trickling in a few at a time for multiple days. Like, they used ot all appear basically at once. Now there's this multiday delay. I have no idea what's going on with it. May be it's failing to send many messages at once or something? I assume same goes on with other feeds, but it's less noticable.
Colby (Mar 16 2026 at 12:36):could be resultmaps being weird
is the review request rss working fine from osmcha?
HellMap (Mar 16 2026 at 12:40):There are only like 2 entries there, so it's not enough to know what would happen there with many entries. They seem to work fine without major delays when there are few to no messages to deliver.
HellMap (Mar 16 2026 at 12:45):Like look at latest notes RSS - https://www.openstreetmap.org/note/5199275 - these were 6 days ago.
markalex (Mar 16 2026 at 12:55):I don't fully get what --max-batch-size does in the b0t.
Does it mean that only set number of messages can be sent for a single run?
If so, combined with the fact that this param is not set in our b0t call, this means that HellMap's spree with notes is just being very-very slowly processed by three items in feed. So in total 12 notes a day.
HellMap (Mar 16 2026 at 13:05):Unless someone changed something somewhere, it didn't used to be like that - all notes would just get dumped whenever the script/b0t runs. May be the param is new? I don't know what changed/broke. I have never looked at the code myself.
markalex (Mar 16 2026 at 13:30):B0t is triggered by github action. Said action installs b0t from repo https://github.com/i-ky/python-zulip-api branch markdownify, and runs it as
$HOME/.local/share/zulip/integrations/rss/rss-bot \
--markdownify \
--site '${{ secrets.zulip_organization_url }}' \
--api-key '${{ secrets.zulip_bot_key }}' \
--user '${{ secrets.zulip_bot_email }}' \
--feed-file rss-feeds \
--data-dir data/ \
--stream RSS
I don't know how i-ky handless updates for said repo from upstream.
And don't have any frame of reference for when it worked, so will not guess anything.
markalex (Mar 16 2026 at 13:34):Param--max-batch-size was added at commit b6e6d8cff009d6c40423a8aaf7ecdeb12eed28a2 in the end of January. So it's possible that it behaves this way very recently.
markalex (Mar 16 2026 at 13:36):Fix is rather easy - add param to the b0t call with some reasonable value for feed size we expect.
HellMap (Mar 16 2026 at 13:43):Hmm, yeah, the default=3 on that seems ridiculous. I guess with that value this is meant to run much more often than whatever it's currently set as. So do we want to run it more often or set the limit higher or both? I honestly would set the batch size to liek 1000 and let it "spam" whatever it needs. I would also run it more than now, may be once an hour.
markalex (Mar 16 2026 at 21:01):I've created PR: https://github.com/OSMLatvija/zulip-rss/pull/3
with batch size set to 100. I think this is a reasonable value.
markalex (Mar 16 2026 at 21:01):I guess now we need @Rihards Olups to approve and merge
markalex (Mar 16 2026 at 21:03):Also, may I request my addition to the organisation of https://github.com/OSMLatvija?
So that I can see owners of repos, and not guess whom to poke with questions :innocent:?
HellMap (Mar 16 2026 at 21:13):Huh, do organizations on github have people with roles like that? I thought only repos can get maintainers and such, but idk. I'm not part of the org either, I'm not even technically admin on Osmalyzer. I guess looking at it, I have no idea who the owner is. I just know it's (probably) rich because it was mentioned.
HellMap (Mar 16 2026 at 21:16):Oh, I guess I am a member in the org. Yes, so richlv is the owner.
markalex (Mar 16 2026 at 21:16):Orgs definitely can have roles. And I thought that it's a default model for orgs, but I'm not 100 sure.
And obviously I have no idea how this one is set
markalex (Mar 17 2026 at 08:09):Seems like we at the end of the queue)
Last batch sent only two notes.
HellMap (Mar 17 2026 at 16:16):Here we go, new spree. Next completion: 20 days.
markalex (Mar 17 2026 at 20:00):Merged. I guess all your 95 notes are inbound in ~4 hours)
HellMap (Mar 17 2026 at 20:04):what! I didn't even get to a 100? ehh... why even bother surveying
HellMap (Mar 17 2026 at 20:06):oh, also I thought github actions runs whenever something is pushed, but I realize this is actually defined in the workflow file, so it's on schedule only for this particular repo. I guess it'll spam them at 3 am.
Rihards Olups (Mar 17 2026 at 20:21):HellMap said:
Oh, I guess I am a member in the org. Yes, so richlv is the owner.
Yes, you have been in the org for quite a long time now :)
HellMap (Mar 18 2026 at 11:32):
That's more like it!
Colby (Mar 18 2026 at 13:33):
HellMap (Mar 18 2026 at 14:45):
Rihards Olups (Mar 18 2026 at 21:12):
Last updated: Apr 27 2026 at 09:12 UTC