Stream: general

Topic: Rimi NSI


view this post on Zulip HellMap (May 29 2024 at 10:47):

Weirdly, iD offers to upgrade generic "Rimi" into "Rimi Mini"
rimi...-mini-question-mark.png

view this post on Zulip HellMap (May 29 2024 at 10:48):

Which I suppose is because there is no version without a qualifier... https://nsi.guide/index.html?t=brands&k=shop&v=supermarket&tt=rimi

view this post on Zulip HellMap (May 29 2024 at 10:49):

Is that actually true in Latvia - are all Rimis one of the variants? I have never paid attention.

view this post on Zulip markalex2209 (May 29 2024 at 10:52):

At least their site indicates that way: https://www.rimi.lv/veikali

Rimi

view this post on Zulip markalex2209 (May 29 2024 at 10:53):

And signs have the qualifier:
image.png

view this post on Zulip markalex2209 (May 29 2024 at 10:54):

Though I cannot find a proper sign on the entrance for "Super" type, and to be honest in doubt about it rn.

view this post on Zulip HellMap (May 29 2024 at 10:54):

I suppose if we tag them all, it won't be an issue. But people may end up mistagging if they don't pay attention. Editors click "fix" a lot without reading anything.

view this post on Zulip markalex2209 (May 29 2024 at 10:56):

Oh, found one:
image.png

view this post on Zulip HellMap (May 29 2024 at 10:59):

markalex2209 said:

Though I cannot find a proper sign on the entrance for "Super" type, and to be honest in doubt about it rn.

Yeah, those exist for sure. The one I saw was literally the Super version and I wanted to upgrade tags first, but it changed to Mini, which is when I noticed this behaviour.
super-rimi-combo.png

view this post on Zulip markalex2209 (May 29 2024 at 11:00):

HellMap said:

I suppose if we tag them all, it won't be an issue. But people may end up mistagging if they don't pay attention. Editors click "fix" a lot without reading anything.

Yes. I requested this change with intention to retag all of them eventually.

Before problem was that if you named shop Rimi Mini, iD would suggest to retag it as

name=Rimi
branch=Mini

And this is incorrect use of branch.
But you'll have to believe me on word here, because I retagged all those with incorrect use of branch (in Latvia) as soon as NSI was updated.

view this post on Zulip HellMap (May 29 2024 at 11:00):

Yeah, the old style was incorrect. I simply didn't event consider what happens when there is no un"branched" version and what iD would actually offer to do

view this post on Zulip HellMap (May 29 2024 at 11:01):

markalex2209 said:

But you'll have to believe me on word here, because I retagged all those with incorrect use of branch (in Latvia) as soon as NSI was updated.

Yeah, no, I saw your edits and know how the branches were used before, so all great :tada:

view this post on Zulip markalex2209 (May 29 2024 at 11:04):

HellMap said:

Yeah, the old style was incorrect. I simply didn't event consider what happens when there is no un"branched" version and what iD would actually offer to do

I believe behaviour is undefined. I've seen some shops suggested to tag to Mini, some - to Hyper with no apparent reason.

view this post on Zulip HellMap (May 29 2024 at 11:05):

Yeah, probably just whatever match result Javascript iD order ends up being


Last updated: Jul 04 2024 at 06:13 UTC